Conversation
6eaa0e8 to
63d135c
Compare
63d135c to
c9f611a
Compare
jasnell
reviewed
Dec 12, 2025
jasnell
reviewed
Dec 12, 2025
jasnell
reviewed
Dec 12, 2025
Collaborator
|
the JS and C++ bits LGTM modulo a couple of nits. Did not look at the python bits. |
c9f611a to
68d4db2
Compare
Contributor
Author
|
Thanks for the review @jasnell! I applied the changes except for moving |
ryanking13
reviewed
Dec 15, 2025
Contributor
ryanking13
left a comment
There was a problem hiding this comment.
Looks okay to me, but I think I don't have enough knowledge on defining a new API in workerd yet, so leaving approval to other people.
ryanking13
approved these changes
Dec 15, 2025
Contributor
ryanking13
left a comment
There was a problem hiding this comment.
Actually, I saw that James approved for the C++ and JS part, so let me approve.
9119b37 to
7102718
Compare
|
The generated output of |
7102718 to
cb2aaf8
Compare
jasnell
approved these changes
Dec 15, 2025
A context manager, to be used like:
```
with patch_env(key1=value1, key2=value2):
# env is patched
# env is restored
```
cb2aaf8 to
19bd541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A context manager, to be used like: