Conversation
jasnell
approved these changes
Dec 9, 2025
fhanau
reviewed
Dec 9, 2025
Contributor
|
Changes LGTM, but we should also update V8's deps in this PR: perfetto (-> 53.0), simdutf (-> 7.7.0) and ICU (-> f27805b7d, commit used in V8's DEPS file with 14.3 branch). Hopefully we'll have automation for this is the future, but for now the V8 update is the best opportunity to do this. |
fhanau
approved these changes
Dec 9, 2025
e5dedee to
0ba2f8b
Compare
0ba2f8b to
d870415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just one trivial conflict in
String::IsFlat.