Conversation
daf134a to
7c7a163
Compare
npaun
reviewed
Dec 4, 2025
npaun
reviewed
Dec 4, 2025
7c7a163 to
d838ba5
Compare
npaun
approved these changes
Dec 4, 2025
Member
npaun
left a comment
There was a problem hiding this comment.
Code LGTM. This is definitely going to slow down CI but could be worth it if it catches bugs that asan-debug doesn't.
Contributor
What do we need this for? Is there precedent for this finding bugs? Note that the asan CI build already uses -Og, so this won't be behaving much differently. |
Member
Author
We have a memory leak in JSG/Rust pull-request that's only caught by the asan release build. |
anonrig
added a commit
that referenced
this pull request
Dec 5, 2025
ds300
pushed a commit
to ds300/workerd
that referenced
this pull request
Dec 9, 2025
This reverts commit 4e6ddc2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds asan release builds