Merged
Conversation
kentonv
reviewed
Nov 28, 2025
Member
kentonv
left a comment
There was a problem hiding this comment.
This PR is missing a test. How did you test the change?
e040500 to
383a212
Compare
383a212 to
ef0743c
Compare
jasnell
approved these changes
Nov 29, 2025
petebacondarwin
approved these changes
Dec 1, 2025
kentonv
reviewed
Dec 1, 2025
| return Reflect.getOwnPropertyDescriptor(inner, prop); | ||
| const desc = Reflect.getOwnPropertyDescriptor(inner, prop); | ||
| if (desc) { | ||
| return { ...desc, enumerable: true }; |
Member
There was a problem hiding this comment.
Odd, why are these properties not already enumerable? Where did they get marked non-enumerable?
Member
There was a problem hiding this comment.
Two possible answers:
- We're doing something weird somewhere causing the properties to not be enumerable on
inner, and we should fix that and remove the work-around here. - Actually the properties have been enumerable all along and the bug report was incorrect? In that case this PR can be reverted except for the test.
Member
There was a problem hiding this comment.
It turns out this PR is a no-op, the test never reproduced the actual bug and passes without the PR. I opened #5647 to revert.
kentonv
added a commit
that referenced
this pull request
Dec 5, 2025
This reverts the changes to worker.ts in ef0743c -- but not the tests. The tests pass without the change, demonstrating that the change did not actually do anything.
kentonv
added a commit
that referenced
this pull request
Dec 5, 2025
This reverts the changes to worker.ts in ef0743c -- but not the tests. The tests pass without the change, demonstrating that the change did not actually do anything. These properties were already enumerable.
kentonv
added a commit
that referenced
this pull request
Dec 5, 2025
Revert #5608 but keep the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5603