Consolidate fast api config into JsgConfig#5598
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Nov 27, 2025
Collaborator
Author
|
For reviewers: there's an internal PR that goes along with this. Please remember to review that as well :-) |
fhanau
approved these changes
Nov 27, 2025
TypeWrapper already uses a configuration mechanism to control its behavior. The fast API mechanism was using a separate mechanism that made TypeWrapper dependent directly on util::Autogate. Simplify by consolidating fast api enablement into JsgConfig.
50fb614 to
4840c8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeWrapper already uses a configuration mechanism to control its behavior. The fast API mechanism was using a separate mechanism that made TypeWrapper dependent directly on util::Autogate. Simplify by consolidating fast api enablement into JsgConfig.