Reset uncaught exception handling after startup execution#5342
Reset uncaught exception handling after startup execution#5342danlapid merged 1 commit intocloudflare:mainfrom
Conversation
|
@mhart was there something more you wanted to check before this lands or should I merge it? |
Ah yeah good point, this slipped off my radar, will look again today |
|
@mhart ping |
7fa7a7f to
d079381
Compare
|
Have played around with this a bunch now including with debug profiler sessions, as well as via I can't observe any difference in behaviour in terms of error handling at the global level, or within a fetch handler, aside from the fact that error throwing/catching is much faster with this change, including during performance profiling. I say this is good to go. |
d079381 to
51b3c61
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5342 +/- ##
==========================================
- Coverage 70.52% 70.51% -0.02%
==========================================
Files 408 408
Lines 108816 108819 +3
Branches 18000 18001 +1
==========================================
- Hits 76739 76729 -10
- Misses 21279 21291 +12
- Partials 10798 10799 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #5332
I've confirmed this keeps the stack for any uncaught errors during startup:
Turning this off any earlier (eg at the end of the Script constructor) is too early:
I've also confirmed this improves performance of running scripts with
throwpatterns as per #5332