Skip to content

Reverting string accounting temporarily to investigate perf impact.#4924

Merged
danlapid merged 1 commit intomainfrom
dlapid/revertStringAccounting
Aug 27, 2025
Merged

Reverting string accounting temporarily to investigate perf impact.#4924
danlapid merged 1 commit intomainfrom
dlapid/revertStringAccounting

Conversation

@danlapid
Copy link
Copy Markdown
Collaborator

No description provided.

@danlapid danlapid requested review from a team as code owners August 27, 2025 22:35
@danlapid danlapid force-pushed the dlapid/revertStringAccounting branch from 979b2e1 to 0439f5c Compare August 27, 2025 22:40
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Aug 27, 2025

CodSpeed Performance Report

Merging #4924 will improve performances by 60.3%

Comparing dlapid/revertStringAccounting (74a31ac) with main (8c37321)1

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
constructor[ApiHeaders] 160.7 ms 100.2 ms +60.3%

Footnotes

  1. No successful run was found on main (97e69d1) during the generation of this report, so 8c37321 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@danlapid danlapid force-pushed the dlapid/revertStringAccounting branch from 0439f5c to c183500 Compare August 27, 2025 22:56
@danlapid danlapid force-pushed the dlapid/revertStringAccounting branch from c183500 to 74a31ac Compare August 27, 2025 23:10
@danlapid danlapid enabled auto-merge August 27, 2025 23:25
@danlapid danlapid disabled auto-merge August 27, 2025 23:33
@danlapid danlapid merged commit 525305b into main Aug 27, 2025
20 of 22 checks passed
@danlapid danlapid deleted the dlapid/revertStringAccounting branch August 27, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants