EW-9365 [o11y] Implement proper Streaming Tail Worker API#4727
Merged
Conversation
danlapid
reviewed
Aug 8, 2025
danlapid
reviewed
Aug 8, 2025
|
The generated output of |
962f460 to
d85c222
Compare
fhanau
commented
Aug 8, 2025
danlapid
reviewed
Aug 8, 2025
Collaborator
danlapid
left a comment
There was a problem hiding this comment.
Reviewed from my phone so might have missed some things
Will take another look tomorrow.
jasnell
reviewed
Aug 8, 2025
2b78ed3 to
c265626
Compare
6bb8c06 to
b6da450
Compare
danlapid
approved these changes
Sep 3, 2025
b6da450 to
ad00f18
Compare
ad00f18 to
ae6daf4
Compare
edmundhung
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the Streaming Tail Worker API as discussed previously, should be a lot more elegant and less error-prone.
What isn't cleaned up yet:
Downstream PR to follow.