improve test coverage of node.js http server by anonrig · Pull Request #4636 · cloudflare/workerd

anonrig · 2025-07-29T17:41:26Z

Adds a new test and removes several todos since they dont apply to our implementation.

src/node/internal/internal_http_server.ts

src/workerd/api/node/tests/http-server-nodejs-test.js

src/node/internal/internal_http_util.ts

src/node/internal/internal_http_incoming.ts

src/node/internal/internal_http_outgoing.ts

src/node/internal/internal_http_server.ts

src/workerd/api/node/tests/http-outgoing-nodejs-test.js

src/node/internal/internal_http_incoming.ts

src/node/internal/internal_http_util.ts

Co-authored-by: James M Snell <jsnell@cloudflare.com>

improve test coverage of node.js http server

086572b

anonrig requested review from a team as code owners July 29, 2025 17:41

anonrig requested review from a team and jasnell July 29, 2025 17:41

jasnell reviewed Jul 29, 2025

View reviewed changes

src/node/internal/internal_http_server.ts Show resolved Hide resolved

jasnell reviewed Jul 29, 2025

View reviewed changes

src/node/internal/internal_http_server.ts Outdated Show resolved Hide resolved

anonrig added 2 commits July 29, 2025 13:48

add more tests

11045b3

add more tests for http-server

395e49e

vicb reviewed Jul 29, 2025

View reviewed changes

src/node/internal/internal_http_server.ts Show resolved Hide resolved

vicb reviewed Jul 29, 2025

View reviewed changes

src/workerd/api/node/tests/http-server-nodejs-test.js Show resolved Hide resolved

handle RFC 7230

915023a

anonrig force-pushed the yagiz/add-more-tests-http-server branch from 73a8a32 to 915023a Compare July 29, 2025 20:40

jasnell reviewed Jul 29, 2025

View reviewed changes

src/workerd/api/node/tests/http-server-nodejs-test.js Show resolved Hide resolved

jasnell reviewed Jul 29, 2025

View reviewed changes

src/node/internal/internal_http_util.ts Show resolved Hide resolved

jasnell reviewed Jul 29, 2025

View reviewed changes

src/node/internal/internal_http_util.ts Outdated Show resolved Hide resolved

add more tests

dbdfea0

anonrig marked this pull request as draft July 29, 2025 23:00

address pr reviews

e3f72b3

anonrig requested a review from jasnell July 30, 2025 16:13