Make spanId a random 64-bit rather than using a counter#3201
Merged
Conversation
489b789 to
dc32557
Compare
anonrig
reviewed
Dec 3, 2024
Member
anonrig
left a comment
There was a problem hiding this comment.
I assume it's not a breaking change, right?
jasnell
commented
Dec 3, 2024
Collaborator
Author
|
Not a breaking change because nothing is relying on this right now. |
anonrig
approved these changes
Dec 3, 2024
5020239 to
63efc4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the streaming tail worker design discussion it was decided that span IDs will follow the otel pattern and will be random 64-bit rather than monotonically increasing counter.