Skip to content

Feat/add gateway categories#2722

Merged
jacobbednarz merged 5 commits intocloudflare:masterfrom
brennoo:feat/add_gateway_categories
Jul 4, 2024
Merged

Feat/add gateway categories#2722
jacobbednarz merged 5 commits intocloudflare:masterfrom
brennoo:feat/add_gateway_categories

Conversation

@brennoo
Copy link
Copy Markdown

@brennoo brennoo commented Jul 3, 2024

This pull request adds support for the ListGatewayCategories endpoint.

Description

Our main driver is that we are looking into have this data available as a data resource in the terraform provider, please let me know if this is the right direction.

Has your change been tested?

besides the test case I created this script and the output seems correct

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

brennoo added 2 commits July 3, 2024 19:54
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
@brennoo brennoo requested a review from jacobbednarz as a code owner July 3, 2024 19:21
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2024

changelog detected ✅

Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Comment thread .changelog/2722.txt Outdated
@jacobbednarz
Copy link
Copy Markdown
Contributor

this functionality already exists in v2 - is there a reason why we cannot use that instead?

Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@brennoo
Copy link
Copy Markdown
Author

brennoo commented Jul 4, 2024

this functionality already exists in v2 - is there a reason why we cannot use that instead?

no specific reason, I think when I was going thru the provider code I read somewhere that v2 should not be used

@jacobbednarz
Copy link
Copy Markdown
Contributor

you may have misunderstood; the Terraform SDKv2 shouldn't be used. the v2 Go library is where we are moving towards.

we can merge this since it's already done but the Terraform provider should use v2 where possible (as that is what we're using going forward).

@brennoo
Copy link
Copy Markdown
Author

brennoo commented Jul 4, 2024

yep it is clear to me I mixed the V2s - if you think there is value in it feel free to merge - I will get back to the provider and when I start something I will use V2 Go library

thanks Jacob!

@jacobbednarz jacobbednarz merged commit 8643509 into cloudflare:master Jul 4, 2024
@github-actions github-actions Bot added this to the v0.100.0 milestone Jul 4, 2024
@brennoo brennoo deleted the feat/add_gateway_categories branch July 5, 2024 06:14
@github-actions
Copy link
Copy Markdown

This functionality has been released in v0.100.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants