Skip to content

AUTH-5608 added warp auth fields to access organizations and apps#1496

Merged
jacobbednarz merged 3 commits intocloudflare:masterfrom
russellkerns:rkerns/AUTH-5608
Feb 5, 2024
Merged

AUTH-5608 added warp auth fields to access organizations and apps#1496
jacobbednarz merged 3 commits intocloudflare:masterfrom
russellkerns:rkerns/AUTH-5608

Conversation

@russellkerns
Copy link
Copy Markdown

Description

Has your change been tested?

Unit tests

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 5, 2024

changelog detected ✅

Comment thread .changelog/1496.txt Outdated
Comment thread access_application.go
HttpOnlyCookieAttribute *bool `json:"http_only_cookie_attribute,omitempty"`
ServiceAuth401Redirect *bool `json:"service_auth_401_redirect,omitempty"`
PathCookieAttribute *bool `json:"path_cookie_attribute,omitempty"`
AllowAuthenticateViaWarp *bool `json:"allow_authenticate_via_warp,omitempty"`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/Warp/WARP

Copy link
Copy Markdown
Contributor

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ping me once the docs land and we can 🚢

@russellkerns
Copy link
Copy Markdown
Author

lgtm, ping me once the docs land and we can 🚢

This was just released in the docs!

@jacobbednarz jacobbednarz merged commit b310f4f into cloudflare:master Feb 5, 2024
@github-actions github-actions Bot added this to the v0.88.0 milestone Feb 5, 2024
github-actions Bot pushed a commit that referenced this pull request Feb 5, 2024
@github-actions
Copy link
Copy Markdown

This functionality has been released in v0.88.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants