Skip to content

feat: added gateway rule notification settings#1463

Merged
jacobbednarz merged 2 commits intocloudflare:masterfrom
rexscaria:rex/gateway-rules-notification-settings-update
Dec 19, 2023
Merged

feat: added gateway rule notification settings#1463
jacobbednarz merged 2 commits intocloudflare:masterfrom
rexscaria:rex/gateway-rules-notification-settings-update

Conversation

@rexscaria
Copy link
Copy Markdown

@rexscaria rexscaria commented Dec 14, 2023

New notification settings are added to the gateway rules as optional settings. This PR adds support for them in the library.

API DOC change at https://developers.cloudflare.com/api/operations/zero-trust-gateway-rules-create-zero-trust-gateway-rule

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 14, 2023

changelog detected ✅

@rexscaria rexscaria changed the title Added gateway rule notification settings feat: added gateway rule notification settings Dec 18, 2023
@jacobbednarz
Copy link
Copy Markdown
Contributor

jacobbednarz commented Dec 19, 2023

once the lint failures and struct namespacing is here, lgtm 🚢

Comment thread teams_rules.go Outdated
Comment thread teams_rules.go Outdated
@jacobbednarz jacobbednarz merged commit 05bc5e6 into cloudflare:master Dec 19, 2023
@github-actions github-actions Bot added this to the v0.84.0 milestone Dec 19, 2023
@github-actions
Copy link
Copy Markdown

This functionality has been released in v0.84.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants