Skip to content

Add support for Opt-In Split Tunnel Overlapping IPs#1454

Merged
jacobbednarz merged 1 commit intocloudflare:masterfrom
da-cf:master
Dec 5, 2023
Merged

Add support for Opt-In Split Tunnel Overlapping IPs#1454
jacobbednarz merged 1 commit intocloudflare:masterfrom
da-cf:master

Conversation

@da-cf
Copy link
Copy Markdown

@da-cf da-cf commented Dec 1, 2023

Description

Add two new fields to the device settings policy. This is to add API support for the Opt-In Split Tunnel Overlapping IPs feature:

  1. lan_allow_minutes (uint) used to set the amount of time a user can access a LAN subnet.
  2. lan_allow_subnet_size (uint) the allowed subnet size for the lan

Has your change been tested?

Added to existing device settings policy tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@da-cf da-cf requested a review from jacobbednarz as a code owner December 1, 2023 23:37
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 1, 2023

changelog detected ✅

Comment thread devices_policy.go Outdated
@jacobbednarz jacobbednarz merged commit fcd3dc6 into cloudflare:master Dec 5, 2023
@github-actions github-actions Bot added this to the v0.83.0 milestone Dec 5, 2023
github-actions Bot pushed a commit that referenced this pull request Dec 5, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 6, 2023

This functionality has been released in v0.83.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants