fix: incorrect data type in UpdateCustomNameserverZoneMetadataParams#1410
Merged
jacobbednarz merged 4 commits intocloudflare:masterfrom Oct 2, 2023
Merged
fix: incorrect data type in UpdateCustomNameserverZoneMetadataParams#1410jacobbednarz merged 4 commits intocloudflare:masterfrom
jacobbednarz merged 4 commits intocloudflare:masterfrom
Conversation
|
changelog detected ✅ |
jacobbednarz
reviewed
Oct 1, 2023
jacobbednarz
reviewed
Oct 1, 2023
jacobbednarz
reviewed
Oct 1, 2023
Contributor
|
thanks for this @rwhelan ✌️ |
|
This functionality has been released in v0.79.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Incorrect data type in UpdateCustomNameserverZoneMetadataParams struct. Using as-is would return a 500.
the
ns_setfield is anintbut the struct is currently setup with astringHas your change been tested?
Found out the API would not accept the request without being an int.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.