Skip to content

AUTH-5460 Add ping_env_id to cloudflare-go#1391

Merged
jacobbednarz merged 1 commit intocloudflare:masterfrom
ajholland:aholland/AUTH-5460
Sep 8, 2023
Merged

AUTH-5460 Add ping_env_id to cloudflare-go#1391
jacobbednarz merged 1 commit intocloudflare:masterfrom
ajholland:aholland/AUTH-5460

Conversation

@ajholland
Copy link
Copy Markdown

Description

ping_env_id is supported as a field in our api already for the Ping identity provider connection
https://developers.cloudflare.com/api/operations/access-identity-providers-list-access-identity-providers

ping isn't currently supported in terraform, adding this field will allow it to be supported in terraform.
(This is the last one I have for now, I don't expect to add more of these in the short term).

Has your change been tested?

Screenshots (if appropriate):

Types of changes

  • [ x] New feature (non-breaking change which adds functionality)

Checklist:

  • [x ] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.
  • [ x] This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 8, 2023

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 35ca0ae into cloudflare:master Sep 8, 2023
@github-actions github-actions Bot added this to the v0.77.0 milestone Sep 8, 2023
github-actions Bot pushed a commit that referenced this pull request Sep 8, 2023
@ajholland ajholland deleted the aholland/AUTH-5460 branch September 11, 2023 14:32
@github-actions
Copy link
Copy Markdown

This functionality has been released in v0.77.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants