Add Ascon-80pq to cipher\ascon#404
Merged
armfazh merged 1 commit intocloudflare:mainfrom Feb 20, 2023
dhcgn:ascon-80pq
Merged
Conversation
Contributor
|
Could you please squash the commits, so we can merge it. |
Contributor
|
I just generated the test vectors file for Ascon80pq using pyascon. https://github.com/meichlseder/pyascon The ciphertext do not matches with the test vector in Go. Could you please confirm it. |
armfazh
requested changes
Feb 20, 2023
Contributor
armfazh
left a comment
There was a problem hiding this comment.
hold until having matching test vectors
armfazh
approved these changes
Feb 20, 2023
Contributor
armfazh
left a comment
There was a problem hiding this comment.
Ok, my local branch of pyascon was outdated. Pyascon impl had a bug (see meichlseder/pyascon#2). Confirming test vectors are ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this repo has a focus on PQ, I would like to suggest including the PQ optimized variant of Ascon.