Use untyped consts for Kyber params#398
Merged
armfazh merged 1 commit intocloudflare:mainfrom Feb 1, 2023
tmthrgd:untyped-kyber
Merged
Use untyped consts for Kyber params#398armfazh merged 1 commit intocloudflare:mainfrom tmthrgd:untyped-kyber
armfazh merged 1 commit intocloudflare:mainfrom
tmthrgd:untyped-kyber
Conversation
Member
|
@armfazh This change should not break compatibility, but it will break compatibility if we need to reintroduce types on these constants for some reason later on. I don't have strong feelings either way. What do you think? |
armfazh
approved these changes
Feb 1, 2023
Contributor
armfazh
left a comment
There was a problem hiding this comment.
Since these are constants (rather than variables) then I think is safe to keep them untyped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two constants are unnecessarily typed. This flows through all the way to the kem/kyber/kyberN packages where they cause
PrivateKeySizeandPublicKeySizeto also be unnecessarily typed.