Build images on base image for target platform#1360
Merged
nickysemenza merged 1 commit intocloudflare:masterfrom Mar 5, 2024
Merged
Build images on base image for target platform#1360nickysemenza merged 1 commit intocloudflare:masterfrom
nickysemenza merged 1 commit intocloudflare:masterfrom
Conversation
Signed-off-by: killianmuldoon <cilliancapi@gmail.com>
killianmuldoon
commented
Feb 22, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.20 | |||
| FROM --platform=${TARGETPLATFORM} golang:1.20 | |||
Contributor
Author
There was a problem hiding this comment.
I tested that golang images are available for all platforms currently supported - linux/arm64, linux/s390x and linux/amd64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensure the docker image is built on the same architecture that it's building for. This ensures that other tools in the docker image - e.g.
bash- will be usable in the image.Fixes #1359