certdb/sql: remove uses of github.com/stretchr/testify/require#1256
Merged
nickysemenza merged 1 commit intocloudflare:masterfrom Aug 1, 2023
Merged
certdb/sql: remove uses of github.com/stretchr/testify/require#1256nickysemenza merged 1 commit intocloudflare:masterfrom
nickysemenza merged 1 commit intocloudflare:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
=======================================
Coverage 52.92% 52.92%
=======================================
Files 76 76
Lines 9169 9169
=======================================
Hits 4853 4853
Misses 3843 3843
Partials 473 473 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a7b6cee to
0d86015
Compare
Contributor
Author
|
Rebased; this one should be ready for review as well, @nickysemenza (thanks for reviewing the other ones!) |
0d86015 to
5111c3d
Compare
Contributor
Author
|
@nickysemenza gentle nudge 🤗 |
This was the only location where this assertion library was used; all other code in this repository used Go's stdlib for assertions. The remaining uses in this package could be replaced without too much trouble, which allowed for the dependency (including its indirect dependencies) to be removed altogether. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
80627e6 to
8d25f25
Compare
Contributor
Author
|
@nickysemenza PTAL 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was the only location where this assertion library was used; all
other code in this repository used Go's stdlib for assertions. The
remaining uses in this package could be replaced without too much
trouble, which allowed for the dependency (including its indirect
dependencies) to be removed altogether.