Skip to content

add unordered, unknown datacontenttype test and errors to v2/event#787

Merged
n3wscott merged 1 commit intocloudevents:mainfrom
n3wscott:782-json-invalid
Jul 27, 2022
Merged

add unordered, unknown datacontenttype test and errors to v2/event#787
n3wscott merged 1 commit intocloudevents:mainfrom
n3wscott:782-json-invalid

Conversation

@n3wscott
Copy link
Copy Markdown
Member

fixes: #782

Signed-off-by: Scott Nichols n3wscott@chainguard.dev

Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
@n3wscott
Copy link
Copy Markdown
Member Author

mind doing a review @agriess ?

Copy link
Copy Markdown

@agriess agriess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@n3wscott n3wscott merged commit 93d324d into cloudevents:main Jul 27, 2022
@n3wscott n3wscott deleted the 782-json-invalid branch July 27, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Json Unmarshaller ignores error around reading 'data' when 'datacontenttype' is invalid

2 participants