add proto test to confirm it is correct#784
Merged
n3wscott merged 1 commit intocloudevents:mainfrom Jul 19, 2022
Merged
Conversation
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
Member
Author
|
It is adding a test, tests passed. I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After much delay, I looked into #759 and concluded the go sdk is doing this correctly, and the java sdk is wrong. The output of a json marshaller is binary data, not a string, thus it should be stored in the binary field of the proto.