Unblock connection receive when context is done#781
Merged
n3wscott merged 1 commit intocloudevents:mainfrom Jul 18, 2022
Merged
Unblock connection receive when context is done#781n3wscott merged 1 commit intocloudevents:mainfrom
n3wscott merged 1 commit intocloudevents:mainfrom
Conversation
a93c929 to
b03f795
Compare
When context is canceled we don't read anymore from `t.incoming` channel because the select clause exists on `ctx.Done`. This change adds the same behavior to the point where `t.incoming` channel is written. Without this the call to `conn.Receive` could block forever given a race condition between a context cancellation and a new incoming message. Furthermore, is always a good practice to listen to `context.Done` on blocking points where a context variable is available. Signed-off-by: Iñigo Garcia Olaizola <11333576+igolaizola@users.noreply.github.com>
b03f795 to
4cec1cf
Compare
n3wscott
approved these changes
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When context is canceled we don't read anymore from
t.incomingchannelbecause the select clause exists on
ctx.Done. This change adds thesame behavior to the point where
t.incomingchannel is written.Without this the call to
conn.Receivecould block forever given arace condition between a context cancellation and a new incoming
message.
Furthermore, is always a good practice to listen to
context.Doneonblocking points where a context variable is available.