Merged
Conversation
Closes: cloudevents#773 Signed-off-by: Michael Gasch <mgasch@vmware.com>
Member
Author
|
Linter workflow seems broken. Running locally only throws a small (existing) nit: golangci-lint run
protocol/http/result_test.go:95:5: S1038: should use t.Errorf(...) instead of t.Error(fmt.Sprintf(...)) (gosimple)
t.Error(fmt.Sprintf("%v, expected result to be IsUndelivered == %t, got %t", tc.name, tc.want, got)) |
n3wscott
approved these changes
Jun 10, 2022
Member
|
Thank you so much @embano1 !! Both for the detailed bug report and the follow-up fix. I will cherry-pick this into the current release as a bug fix and we will get this out. 🙏 🙏 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where requests with a body (event) are not always retried due to the underlying
net/httpthrowing*url.Errorbecause of body and content-length mismatch (body is empty and not reset upon retry). See #773 for details.The tests did not catch this as they were not doing behaving as a real HTTP server (just mocking
RoundTripper) and also not carrying an event body (which would not trigger this behavior).nil) during retriesGetBodyfunc only if it is not already set (the sdk already does this currently)Closes: #773
Signed-off-by: Michael Gasch mgasch@vmware.com