feat(client): Add option to make receive callback blocking#771
Merged
n3wscott merged 2 commits intocloudevents:mainfrom May 9, 2022
Merged
Conversation
Signed-off-by: James Yu <jyu@confluent.io>
Signed-off-by: James Yu <jyu@confluent.io>
bc19cf1 to
81a6caa
Compare
Member
|
The lint error seems to be related to go 1.18 and the linter. Not related to this PR. |
n3wscott
approved these changes
May 9, 2022
Member
n3wscott
left a comment
There was a problem hiding this comment.
Nice work, simple fix, thanks a bunch!!
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #770
blocking_testto ensure whenpollRoutinesis1AND it's blocking, the events are processed in serialized manner.Manual Testing
Run the example receiver code: https://gist.github.com/liu-cong/a132fe8629715419c7a58ee20001d071
It retrieves the Ce-Sleep attribute from the event and sleep for that period of time.
Then send a few events to the receiver using curl,
Without
blockingCallbackflagcloudevents.NewClient(p, client.WithPollGoroutines(1))Sent 3 events, finish at the same time
With
blockingCallbackflagcloudevents.NewClient(p, client.WithBlockingCallback(), client.WithPollGoroutines(1))Finished one after another
Signed-off-by: James Yu jyu@confluent.io