fix: SetExtension cannot override core attributes#720
Merged
n3wscott merged 1 commit intocloudevents:mainfrom Oct 28, 2021
Merged
fix: SetExtension cannot override core attributes#720n3wscott merged 1 commit intocloudevents:mainfrom
n3wscott merged 1 commit intocloudevents:mainfrom
Conversation
Member
Author
|
Up for discussion: Where can I reference the |
n3wscott
reviewed
Oct 4, 2021
v2/event/extensions.go
Outdated
| } | ||
|
|
||
| // TODO: not safe, can be bypassed with a ce-ce- prefix | ||
| trimmed := strings.TrimPrefix(key, "ce-") |
Member
There was a problem hiding this comment.
not needed, if the key has a - it is not a valid extension per the test on 70.
Member
|
are you going to do the todos here or a follow up? |
Member
Author
|
Sorry, sorry. Any ideas on the second comment instead of reinventing the event attributes wheel? |
n3wscott
reviewed
Oct 26, 2021
785d926 to
52095dc
Compare
Closes: cloudevents#709 Signed-off-by: Michael Gasch <mgasch@vmware.com>
n3wscott
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail if
SetExtensionis called with a core attribute.TODO:
V03Closes: #709
Signed-off-by: Michael Gasch mgasch@vmware.com