Skip to content

Fix nats integration tests#710

Merged
n3wscott merged 1 commit intocloudevents:mainfrom
benmoss:fix-nats
Aug 18, 2021
Merged

Fix nats integration tests#710
n3wscott merged 1 commit intocloudevents:mainfrom
benmoss:fix-nats

Conversation

@benmoss
Copy link
Copy Markdown
Contributor

@benmoss benmoss commented Aug 18, 2021 •
edited
Loading

Not really sure why this was broken, I was getting this error when running these locally:

go test -v -parallel 1 -timeout 10m -race -covermode=atomic -coverprofile=coverage.tmp -coverpkg "$COVERPKG" github.com/cloudevents/sdk-go/test/integration/nats
go: github.com/cloudevents/sdk-go/protocol/nats/v2@v2.5.0 requires
        github.com/nats-io/nats-server/v2@v2.3.4: missing go.sum entry; to add it:
        go mod download github.com/nats-io/nats-server/v2

I ran go mod tidy and it made these changes to go.mod and go.sum. I bumped the nats image just since it seemed out of date.

@benmoss
Fix nats integration tests
31d1240 
Signed-off-by: Ben Moss <benm@vmware.com>
@n3wscott
Copy link
Copy Markdown
Member

n3wscott commented Aug 18, 2021

GREEN again!!
Thanks Ben!!

LGTM

@n3wscott n3wscott merged commit 70febdc into cloudevents:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benmoss @n3wscott