fix EventReceiver does not propagate request context#540
Merged
slinkydeveloper merged 2 commits intocloudevents:masterfrom Jun 24, 2020
Merged
fix EventReceiver does not propagate request context#540slinkydeveloper merged 2 commits intocloudevents:masterfrom
slinkydeveloper merged 2 commits intocloudevents:masterfrom
Conversation
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
| }) | ||
| } | ||
|
|
||
| handler := func(ctx context.Context) error { |
Member
There was a problem hiding this comment.
can you rename this variable to eventReceiver?
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| rh, err := client.NewHTTPReceiveHandler(context.Background(), p, handler) |
Member
There was a problem hiding this comment.
and rename this with httpHandler
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
Oh, sorry I was wrong, conflicts with above.
| ctx = cloudevents.ContextWithTarget(ctx, ts.URL+"/test") | ||
|
|
||
| result := c.Send(ctx, event) | ||
| if cloudevents.IsNACK(result) || !cloudevents.IsACK(result) { |
Member
There was a problem hiding this comment.
you can change this with
require.True(t, cloudevents.IsACK(result))
Signed-off-by: Mitsuo Heijo <mitsuo.heijo@gmail.com>
Contributor
Author
|
Thanks for your reviewing, has fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug the context value set by HTTP middleware etc. was not propagated to the handler.
Signed-off-by: Mitsuo Heijo mitsuo.heijo@gmail.com