zsh: fix passing arguments in dynamic completion#6000
Merged
epage merged 2 commits intoclap-rs:masterfrom May 30, 2025
mernen:fix-zsh-dynamic-completion
Merged
zsh: fix passing arguments in dynamic completion#6000epage merged 2 commits intoclap-rs:masterfrom mernen:fix-zsh-dynamic-completion
epage merged 2 commits intoclap-rs:masterfrom
mernen:fix-zsh-dynamic-completion
Conversation
Member
|
@mernen when posting PRs in intermediate states, it would be helpful to ping people because title renames and pushes don't cause notifications so I didn't know this was in a ready state. |
Contributor
Author
|
Oh, I see — the PR wasn't a draft, but GitHub automatically used the first commit's message as the title, and I can see how it looks incomplete from that. I have to pay more attention to the fields before submitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5979 for good.
I'm not familiar with zsh, and its completion engine is completely different from Bash's, but my experiments suggest it's really just a case of proper array expansion, which is more or less the same thing on both shells.