fix(complete): remove duplicate bash subcmd cases caused by aliases#5846
Merged
epage merged 1 commit intoclap-rs:masterfrom Dec 16, 2024
Merged
fix(complete): remove duplicate bash subcmd cases caused by aliases#5846epage merged 1 commit intoclap-rs:masterfrom
epage merged 1 commit intoclap-rs:masterfrom
Conversation
**Problem:** Visible alias completions were causing duplicate case conditions when offering subcommand completions, due to the fact that they share the same function name as the command they are aliasing. **Solution:** Deduplicate them so as to not redefine the exact same case statement logic.
1dcc80a to
48ff72b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visible alias completions were causing duplicate case conditions when offering subcommand completions, due to the fact that they share the same function name as the command they are aliasing. This commit deduplicates them so as to not redefine the exact same case statement logic.