chore(deps): update rust crate shlex to v1.3.0 [security]#5323
Merged
renovate[bot] merged 1 commit intomasterfrom Jan 22, 2024
Merged
chore(deps): update rust crate shlex to v1.3.0 [security]#5323renovate[bot] merged 1 commit intomasterfrom
renovate[bot] merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.2.0->1.3.0GitHub Vulnerability Alerts
GHSA-r7qv-8r2h-pg27
Issue 1: Failure to quote characters
Affected versions of this crate allowed the bytes
{and\xa0to appearunquoted and unescaped in command arguments.
If the output of
quoteorjoinis passed to a shell, then what should be asingle command argument could be interpreted as multiple arguments.
This does not directly allow arbitrary command execution (you can't inject a
command substitution or similar). But depending on the command you're running,
being able to inject multiple arguments where only one is expected could lead
to undesired consequences, potentially including arbitrary command execution.
The flaw was corrected in version 1.2.1 by escaping additional characters.
Updating to 1.3.0 is recommended, but 1.2.1 offers a more minimal fix if
desired.
Workaround: Check for the bytes
{and\xa0inquote/joininput oroutput.
(Note:
{is problematic because it is used for glob expansion.\xa0isproblematic because it's treated as a word separator in specific
environments.)
Issue 2: Dangerous API w.r.t. nul bytes
Version 1.3.0 deprecates the
quoteandjoinAPIs in favor oftry_quoteand
try_join, which behave the same except that they haveResultreturntype, returning
Errif the input contains nul bytes.Strings containing nul bytes generally cannot be used in Unix command arguments
or environment variables, and most shells cannot handle nul bytes even
internally. If you try to pass one anyway, then the results might be
security-sensitive in uncommon scenarios. More details here.
Due to the low severity, the behavior of the original
quoteandjoinAPIshas not changed; they continue to allow nuls.
Workaround: Manually check for nul bytes in
quote/joininput or output.Issue 3: Lack of documentation for interactive shell risks
The
quotefamily of functions does not and cannot escape control characters.With non-interactive shells this is perfectly safe, as control characters have
no special effect. But if you writing directly to the standard input of an
interactive shell (or through a pty), then control characters can cause
misbehavior including arbitrary command injection.
This is essentially unfixable, and has not been patched. But as of version
1.3.0, documentation has been added.
Future versions of
shlexmay add API variants that avoid the issue at thecost of reduced portability.
Release Notes
comex/rust-shlex (shlex)
v1.3.0try_equivalents that complain about nul bytes.v1.2.1{and\xa0are now escaped by quoting functions.Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.