Skip to content

cilium-cli: add connectivity test for service loopback#42590

Merged
tklauser merged 2 commits intocilium:mainfrom
saiaunghlyanhtet:pr/conn-test-service-loopback
Feb 20, 2026
Merged

cilium-cli: add connectivity test for service loopback#42590
tklauser merged 2 commits intocilium:mainfrom
saiaunghlyanhtet:pr/conn-test-service-loopback

Conversation

@saiaunghlyanhtet
Copy link
Copy Markdown
Member

@saiaunghlyanhtet saiaunghlyanhtet commented Nov 4, 2025 •
edited
Loading

Connectivity tests to catch regressions after service loopback support for IPv6 is available.

Connectivity tests for service loopback to catch regressions

Fixes: #33194

@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 4, 2025
@github-actions github-actions Bot added cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary labels Nov 4, 2025
@saiaunghlyanhtet saiaunghlyanhtet marked this pull request as ready for review November 4, 2025 14:08
@saiaunghlyanhtet saiaunghlyanhtet requested review from a team as code owners November 4, 2025 14:08
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. feature/ipv6 Relates to IPv6 protocol support labels Nov 4, 2025
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 4, 2025
@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch from c8427a8 to bfd6076 Compare November 4, 2025 14:13
@saiaunghlyanhtet saiaunghlyanhtet changed the title cilium-cli: add connectivit test for service loopback cilium-cli: add connectivity test for service loopback Nov 4, 2025
@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch from bfd6076 to 33fde89 Compare November 4, 2025 14:31
julianwiedmann
julianwiedmann reviewed Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Some initial thoughts below.

Comment thread cilium-cli/connectivity/tests/service.go
Comment thread cilium-cli/connectivity/tests/service.go Outdated
Comment thread cilium-cli/connectivity/builder/service_loopback.go Outdated
@julianwiedmann julianwiedmann added the area/loadbalancing Impacts load-balancing and Kubernetes service implementations label Nov 4, 2025
@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch 2 times, most recently from b8effae to eaedb76 Compare November 5, 2025 04:38
@julianwiedmann
Copy link
Copy Markdown
Member

julianwiedmann commented Nov 6, 2025

/ci-e2e-upgrade

@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch from eaedb76 to 0df27c2 Compare December 1, 2025 12:49
@pchaigno pchaigno enabled auto-merge December 1, 2025 18:10
auto-merge was automatically disabled December 18, 2025 11:07

Head branch was pushed to by a user without write access

@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch from 0df27c2 to 6bcf443 Compare December 18, 2025 11:07
@saiaunghlyanhtet
Copy link
Copy Markdown
Member Author

saiaunghlyanhtet commented Dec 18, 2025

Re-basing. Any update on this?

@julianwiedmann
Copy link
Copy Markdown
Member

julianwiedmann commented Dec 18, 2025

Re-basing. Any update on this?

it's on my plate, just backlogged - sorry. Probably won't get to it before the holiday break.

@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch from 6bcf443 to 4453d88 Compare January 5, 2026 06:18
julianwiedmann
julianwiedmann reviewed Jan 7, 2026
View reviewed changes
Comment thread cilium-cli/connectivity/tests/service.go Outdated
Comment thread cilium-cli/connectivity/tests/service.go Outdated
@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch from 4453d88 to a6bb917 Compare January 7, 2026 15:03
@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch 2 times, most recently from 82969cf to 14838d4 Compare January 8, 2026 01:12
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Feb 15, 2026
@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch from 14838d4 to 7a95cdd Compare February 15, 2026 08:57
@saiaunghlyanhtet
Copy link
Copy Markdown
Member Author

saiaunghlyanhtet commented Feb 15, 2026

/test

@github-actions github-actions Bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Feb 16, 2026
@pchaigno
Copy link
Copy Markdown
Member

pchaigno commented Feb 16, 2026

@ysksuzuki @viktor-kurchenko We're waiting for your reviews here 🥺

viktor-kurchenko
viktor-kurchenko approved these changes Feb 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pchaigno pchaigno enabled auto-merge February 17, 2026 09:52
tklauser
tklauser reviewed Feb 18, 2026
View reviewed changes
Comment thread cilium-cli/connectivity/builder/service_loopback.go
@saiaunghlyanhtet
cilium-cli: refactor the L7LBClientPods workload
ccb183c 
Refactor the L7LBClientPods workload
so that we don't have to depend on features.L7LoadBalancer for running the tests
that use L7LBClientPods. Also add a new non-L7 service to BPF hairpin
testing.

Signed-off-by: saiaunghlyanhtet <saiaunghlyanhtet2003@gmail.com>
@saiaunghlyanhtet
cilium-cli: add connectivity test for service loopback
349d7a6 
Signed-off-by: saiaunghlyanhtet <saiaunghlyanhtet2003@gmail.com>
auto-merge was automatically disabled February 19, 2026 01:10

Head branch was pushed to by a user without write access

@saiaunghlyanhtet saiaunghlyanhtet force-pushed the pr/conn-test-service-loopback branch from 7a95cdd to 349d7a6 Compare February 19, 2026 01:10
@saiaunghlyanhtet saiaunghlyanhtet requested a review from a team as a code owner February 19, 2026 01:10
@saiaunghlyanhtet
Copy link
Copy Markdown
Member Author

saiaunghlyanhtet commented Feb 19, 2026

/test

tklauser
tklauser approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser tklauser enabled auto-merge February 19, 2026 08:14
bimmlerd
bimmlerd approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODEOWNERS lgtm

@tklauser
Copy link
Copy Markdown
Member

tklauser commented Feb 19, 2026

@cilium/sig-lb @ysksuzuki could you please take a look?

ysksuzuki
ysksuzuki approved these changes Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ysksuzuki ysksuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tklauser tklauser added this pull request to the merge queue Feb 20, 2026
Merged via the queue into cilium:main with commit bd7a99e Feb 20, 2026
82 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tklauser tklauser tklauser approved these changes

@ysksuzuki ysksuzuki ysksuzuki approved these changes

@bimmlerd bimmlerd bimmlerd approved these changes

@viktor-kurchenko viktor-kurchenko viktor-kurchenko approved these changes

@julianwiedmann julianwiedmann Awaiting requested review from julianwiedmann

Assignees

No one assigned

Labels

area/CI Continuous Integration testing issue or flake area/CI-improvement Topic or proposal to improve the Continuous Integration workflow area/loadbalancing Impacts load-balancing and Kubernetes service implementations cilium-cli This PR contains changes related with cilium-cli cilium-cli-exclusive This PR only impacts cilium-cli binary feature/ipv6 Relates to IPv6 protocol support release-note/ci This PR makes changes to the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kpr: stabilize Service handling for loopback connections

7 participants

@saiaunghlyanhtet @julianwiedmann @pchaigno @tklauser @ysksuzuki @bimmlerd @viktor-kurchenko