Skip to content

workflows/conformance-ginkgo: fix steps for stable branches#41599

Merged
aanm merged 1 commit intomainfrom
pr/fix-cilium-cli-for-stable-branches
Sep 10, 2025
Merged

workflows/conformance-ginkgo: fix steps for stable branches#41599
aanm merged 1 commit intomainfrom
pr/fix-cilium-cli-for-stable-branches

Conversation

@aanm
Copy link
Copy Markdown
Member

@aanm aanm commented Sep 9, 2025

On stable branches we are not building cilium-cli image and therefore the CI images don't exist for the commit that we want to retrieve the cilium-cli binary from. This causes the CI to fail on stable branches. Thus, we need to add a new step that only runs when cilium-cli binary exists which permits for stable branches to run successfully.

Fixes: 8222614 (".github/worfklows: copy cilium-cli binary from container")

On stable branches we are not building cilium-cli image and therefore
the CI images don't exist for the commit that we want to retrieve the
cilium-cli binary from. This causes the CI to fail on stable branches.
Thus, we need to add a new step that only runs when cilium-cli binary
exists which permits for stable branches to run successfully.

Fixes: 8222614 (".github/worfklows: copy cilium-cli binary from container")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the backport/author The backport will be carried out by the author of the PR. label Sep 9, 2025
@aanm aanm requested a review from a team as a code owner September 9, 2025 15:48
@aanm aanm requested a review from a team as a code owner September 9, 2025 15:48
@aanm aanm added needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Sep 9, 2025
@aanm aanm requested a review from brlbil September 9, 2025 15:48
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 9, 2025
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Sep 9, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 9, 2025
@aanm aanm requested review from Artyop and removed request for brlbil September 9, 2025 15:49
@aanm aanm enabled auto-merge September 9, 2025 15:49
@aanm
Copy link
Copy Markdown
Member Author

aanm commented Sep 9, 2025

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 9, 2025
@aanm aanm added this pull request to the merge queue Sep 10, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 10, 2025
Merged via the queue into main with commit 8e48b7c Sep 10, 2025
141 checks passed
@aanm aanm deleted the pr/fix-cilium-cli-for-stable-branches branch September 10, 2025 07:53
@aanm aanm added backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. and removed needs-backport/1.18 This PR / issue needs backporting to the v1.18 branch labels Sep 10, 2025
@aanm aanm removed needs-backport/1.16 needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Sep 10, 2025
@aanm aanm added the backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. label Sep 10, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-pending/1.18 The backport for Cilium 1.18.x for this PR is in progress. labels Sep 10, 2025
@cilium-release-bot cilium-release-bot bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/author The backport will be carried out by the author of the PR. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. backport-done/1.18 The backport for Cilium 1.18.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

4 participants