Skip to content

docs: Add new IAM permissions requirements to upgrade notes#41374

Merged
joestringer merged 1 commit intov1.18from
pr/HadrienPatte/1.18-upgrade-notes
Aug 25, 2025
Merged

docs: Add new IAM permissions requirements to upgrade notes#41374
joestringer merged 1 commit intov1.18from
pr/HadrienPatte/1.18-upgrade-notes

Conversation

@HadrienPatte
Copy link
Copy Markdown
Member

@HadrienPatte HadrienPatte commented Aug 25, 2025

See #37229

@HadrienPatte
docs: Add new IAM permissions requirements to upgrade notes
4bde0e9 
See #37229

Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Aug 25, 2025
@HadrienPatte HadrienPatte marked this pull request as ready for review August 25, 2025 18:41
@HadrienPatte HadrienPatte requested a review from a team as a code owner August 25, 2025 18:41
@joestringer
Copy link
Copy Markdown
Member

joestringer commented Aug 25, 2025

Thanks for the patch. Shouldn't this go into main first then be backported to v1.18?

@HadrienPatte
Copy link
Copy Markdown
Member Author

HadrienPatte commented Aug 25, 2025

Shouldn't this go into main first then be backported to v1.18?

Yes, I wondered about that too, but this is part of the 1.18 Upgrade Notes section and on main this section has been replaced by the future 1.19 Upgrade Notes section. So I believe this patch can't go through the regular main+backport flow.

@joestringer
Copy link
Copy Markdown
Member

joestringer commented Aug 25, 2025

I see. That seems fair enough. I see also that this permission is in fact listed on the ENI page as well, so users configuring this mode in future should have the opportunity to discover this requirement. SGTM 👍

joestringer
joestringer approved these changes Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that this will show up under /v1.18 shortly, then /stable only after the next patch release (due to the way RTD generates the /stable documentation).

@joestringer joestringer enabled auto-merge August 25, 2025 21:47
@joestringer
Copy link
Copy Markdown
Member

joestringer commented Aug 25, 2025

/test

@joestringer joestringer added this pull request to the merge queue Aug 25, 2025
Merged via the queue into v1.18 with commit b6220fe Aug 25, 2025
68 checks passed
@joestringer joestringer deleted the pr/HadrienPatte/1.18-upgrade-notes branch August 25, 2025 22:00
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joestringer joestringer joestringer approved these changes

Assignees

No one assigned

Labels

backport/1.18 This PR represents a backport for Cilium 1.18.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HadrienPatte @joestringer