metrics: skip health metrics collection when healthchecking is disabled#41297
Merged
metrics: skip health metrics collection when healthchecking is disabled#41297
Conversation
Member
Author
|
/test |
derailed
requested changes
Aug 21, 2025
Contributor
derailed
left a comment
There was a problem hiding this comment.
@HadrienPatte Nice work!
Currently, disabling agent health checks with `--enable-health-checking=false`, causes a lot of error logs like > Error while getting cilium-health status: Get "http://localhost/v1beta/status": dial unix /var/run/cilium/health.sock: connect: no such file or directory This PR updates the agent metrics collection logic to skip collecting health related metrics if health checking is disabled. Signed-off-by: Hadrien Patte <hadrien.patte@datadoghq.com>
319a687 to
2db9e65
Compare
Member
Author
|
/test |
Member
|
@HadrienPatte Could you add a small release note like |
derailed
approved these changes
Aug 25, 2025
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, disabling agent health checks with
--enable-health-checking=false, causes a lot of error logs likeThis PR updates the agent metrics collection logic to skip collecting health related metrics if health checking is disabled.