testutils: differentiate {Test,Benchmark}Privileged and fix benchmarks#41007
Merged
testutils: differentiate {Test,Benchmark}Privileged and fix benchmarks#41007
Conversation
As of today, we identify privileged tests with the "TestPrivileged" prefix in their name. However, that doesn't hold true for benchmarks requiring privileges, which are always skipped given their prefix doesn't match "TestPrivileged". This commit patches our current logic to introduce a new "BenchmarkPrivileged" prefix to identify such benchmarks requiring privileged access. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
This commits adjusts the prefix of all benchmarks requiring privileged access with the new "BenchmarkPrivileged" prefix. Signed-off-by: Simone Magnani <simone.magnani@isovalent.com>
Contributor
Author
|
/test |
rgo3
approved these changes
Aug 8, 2025
brlbil
approved these changes
Aug 8, 2025
gentoo-root
approved these changes
Aug 11, 2025
Contributor
Author
|
@cilium/committers I believe this can be merged. PTAL at labels 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of today, we identify privileged tests with the "TestPrivileged" prefix in their name. However, that doesn't hold true for benchmarks requiring privileges, which are always skipped given their prefix doesn't match "TestPrivileged".
This PR patches our current logic to introduce a new "BenchmarkPrivileged" prefix to identify such benchmarks requiring privileged access. In addition, it adjusts the prefix of all benchmarks requiring privileged with the new prefix.