Conversation
Member
Author
|
/test |
Member
Author
|
/test |
1 similar comment
Member
Author
|
/test |
741a2da to
91db4c7
Compare
Member
Author
|
/test |
91db4c7 to
5613b7a
Compare
Member
Author
|
/test |
joamaki
approved these changes
Aug 13, 2025
Contributor
joamaki
left a comment
There was a problem hiding this comment.
operator logging changes LGTM
Some CI environment variables were missing in our CI for some images. We should enable them not only for the agent. Signed-off-by: André Martins <andre@cilium.io>
Performing the Sanitization of a network policy will result its object on being modified, therefore we need to make sure we DeepCopy the object before doing it. Fixes: 38f30ae ("policy: parse policies in the operator, update informational conditions") Signed-off-by: André Martins <andre@cilium.io>
This key is already defined in the logger thus we don't need to set it again when creating a sub-logger. Since slog contains a slice of keys, and not a map as logrus, they key will be appended to the existing keys which will result in duplicated keys. Signed-off-by: André Martins <andre@cilium.io>
Instead of using the duplicated log key "resource" we should be more specific and use the "parentResource" log key instead. Signed-off-by: André Martins <andre@cilium.io>
5613b7a to
4941d44
Compare
Member
Author
|
/test |
viktor-kurchenko
approved these changes
Aug 15, 2025
Member
Author
|
/test |
sayboras
approved these changes
Aug 21, 2025
gandro
approved these changes
Aug 21, 2025
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some CI environment variables were missing in our CI for some images. We should enable them not only for the agent.