fix(tz): reject TZ offset hour of 24 to avoid FixedOffset overflow#1787
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
==========================================
+ Coverage 89.86% 89.88% +0.01%
==========================================
Files 35 35
Lines 13769 13775 +6
==========================================
+ Hits 12374 12381 +7
+ Misses 1395 1394 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1480.
parse_offsetin the POSIX TZ string parser accepted an offset hour of 24 (0..=24). A 24-hour offset is 86400 seconds, which does not fit in aFixedOffset(limited to ±23:59:59 / ±86399 seconds), so a TZ string such aspBB24parsed successfully but later panicked when the offset was converted to aFixedOffset.This caps the offset hour at 23, matching the
FixedOffsetrange, so an out-of-range offset is rejected at parse time withInvalidTzStringinstead of panicking downstream.This change is semver-compatible, so it targets
main.Added
test_invalid_offset_hourcovering hour 24 (with and without sign) and the maximum valid23:59:59offset.