Add num_days_in_month method to Datelike trait#1673
Merged
djc merged 1 commit intochronotope:mainfrom Mar 17, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
==========================================
+ Coverage 91.06% 91.08% +0.01%
==========================================
Files 37 37
Lines 17454 17469 +15
==========================================
+ Hits 15895 15912 +17
+ Misses 1559 1557 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
reviewed
Mar 11, 2025
Member
djc
left a comment
There was a problem hiding this comment.
Please squash your commits into clean history:
- One for the
in_leap_year()addition - One for adding
num_days_in_month()
3cc0e67 to
9c2f78e
Compare
9c2f78e to
97ee174
Compare
djc
approved these changes
Mar 17, 2025
Member
|
Thanks! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent
num_daysaddition to theMonthtype is great, but it could be even better if we took it just a little bit further.This change adds a
num_days_in_monthfunction to theDateliketrait.