Skip to content

addListener and removeListener should be only invoked on truthy values#11685

Merged
etimberg merged 1 commit intochartjs:masterfrom
DAcodedBEAT:event-listener-arg-validation
Feb 28, 2024
Merged

addListener and removeListener should be only invoked on truthy values#11685
etimberg merged 1 commit intochartjs:masterfrom
DAcodedBEAT:event-listener-arg-validation

Conversation

@DAcodedBEAT
Copy link
Copy Markdown
Contributor

@DAcodedBEAT DAcodedBEAT commented Feb 27, 2024

As reported in #11677, this issue is experienced in a few libraries integrating chart.js (such as #11295, samber/chartjs-plugin-datasource-prometheus#40, sgratzl/chartjs-chart-graph#79)

TypeError: Cannot read properties of null (reading 'addEventListener')
  at addListener(../../node_modules/chart.js/dist/chart.js:3234:8)
  at createProxyAndListen(../../node_modules/chart.js/dist/chart.js:3360:15)
  at DomPlatform.addEventListener(../../node_modules/chart.js/dist/chart.js:3406:21)
  at _add(../../node_modules/chart.js/dist/chart.js:6216:16)
  at <anonymous>(../../node_modules/chart.js/dist/chart.js:6224:41)
  at each(../../node_modules/chart.js/dist/chunks/helpers.segment.js:56:12)
  at _a.bindUserEvents(../../node_modules/chart.js/dist/chart.js:6224:10)
  at _a.bindEvents(../../node_modules/chart.js/dist/chart.js:6205:10)
  at _a._checkEventBindings(../../node_modules/chart.js/dist/chart.js:5903:12)
  at _a.update(../../node_modules/chart.js/dist/chart.js:5852:10)
  at this._doResize(../../node_modules/chart.js/dist/chart.js:5620:46)
  at sentryWrapped(../../node_modules/@sentry/browser/esm/helpers.js:37:17)

By ensuring that addEventListener and removeEventListener are called on truth-y values, Chart.js can prevent these TypeErrors from occurring and therefore make implementing applications more stable when integrating chart.js.

Closes #11677

@DAcodedBEAT DAcodedBEAT mentioned this pull request Feb 27, 2024
Closed
@LeeLenaleee LeeLenaleee added this to the Version 4.5.0 milestone Feb 27, 2024
@DAcodedBEAT
Copy link
Copy Markdown
Contributor Author

DAcodedBEAT commented Feb 28, 2024

Thanks for the approvals @LeeLenaleee and @etimberg!
When can this be merged and what is the ETA for it's release?

@etimberg etimberg merged commit bbdaa6a into chartjs:master Feb 28, 2024
@etimberg
Copy link
Copy Markdown
Member

etimberg commented Feb 28, 2024

Merged it now; we don't have a date on a next release but I think we're getting close. @LeeLenaleee thoughts?

@LeeLenaleee
Copy link
Copy Markdown
Collaborator

LeeLenaleee commented Feb 28, 2024

There are no enhancements merged so if we rename the milsestone from 4.5.0 to 4.4.2 and create a new 4.5.0 we can do a bugfix release

@etimberg
Copy link
Copy Markdown
Member

etimberg commented Feb 28, 2024

i renamed it

@raymondhtet raymondhtet mentioned this pull request May 29, 2024
Closed
@DawoudIO DawoudIO mentioned this pull request Jun 7, 2024
Merged
@victorsclr victorsclr mentioned this pull request Jun 7, 2024
Open
@Jin-Sun-tts Jin-Sun-tts mentioned this pull request Jun 7, 2024
Merged
@alfonsserra alfonsserra mentioned this pull request Jun 7, 2024
Closed
@MiguelPelegrina MiguelPelegrina mentioned this pull request Jun 7, 2024
Merged
@brmzkw brmzkw mentioned this pull request Jun 7, 2024
Open
@respencer respencer mentioned this pull request Jun 7, 2024
Closed
@vigneshshettyin vigneshshettyin mentioned this pull request Jun 8, 2024
Merged
@dariosalvi78 dariosalvi78 mentioned this pull request Jun 15, 2024
Merged
@stevenalp207 stevenalp207 mentioned this pull request Jun 17, 2024
Merged
@DallinAllred DallinAllred mentioned this pull request Jun 22, 2024
Merged
@wanissr wanissr mentioned this pull request Jun 22, 2024
Open
@bwilliford bwilliford mentioned this pull request Jun 26, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Jul 5, 2024
Closed
@raymondhtet raymondhtet mentioned this pull request Jul 14, 2024
Closed
@kalbroni7 kalbroni7 mentioned this pull request Jul 17, 2024
Open
@faragashraf faragashraf mentioned this pull request Jul 18, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Aug 16, 2024
Open
@DAcodedBEAT DAcodedBEAT deleted the event-listener-arg-validation branch August 30, 2024 23:01
@0xk4b1r 0xk4b1r mentioned this pull request Sep 7, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Sep 7, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Sep 8, 2024
Open
@diaz-rigo diaz-rigo mentioned this pull request Sep 9, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 12, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Sep 13, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 16, 2024
Open
@karencapiiro karencapiiro mentioned this pull request Sep 17, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Sep 18, 2024
Open
@jcampb98 jcampb98 mentioned this pull request Sep 20, 2024
Merged
@scottwad scottwad mentioned this pull request Sep 24, 2024
Open
@mytamDo mytamDo mentioned this pull request Sep 24, 2024
Open
@raymondhtet raymondhtet mentioned this pull request Sep 25, 2024
Open
@bagulm123 bagulm123 mentioned this pull request Oct 1, 2024
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 27, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 27, 2024
Open
@ngihoul ngihoul mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etimberg etimberg etimberg approved these changes

@LeeLenaleee LeeLenaleee LeeLenaleee approved these changes

Assignees

No one assigned

Labels

type: bug

Projects

None yet

Milestone

Version 4.4.2

Development

Successfully merging this pull request may close these issues.

Cannot read properties of null (reading 'addEventListener')

3 participants

@DAcodedBEAT @etimberg @LeeLenaleee