bugfix #10896 - Changed 'r' to optional for BubbleChart#11662
Merged
etimberg merged 1 commit intochartjs:masterfrom Feb 12, 2024
Merged
bugfix #10896 - Changed 'r' to optional for BubbleChart#11662etimberg merged 1 commit intochartjs:masterfrom
etimberg merged 1 commit intochartjs:masterfrom
Conversation
etimberg
approved these changes
Feb 11, 2024
kurkle
approved these changes
Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change to
BubbleDataPointto setras an optional parameter.As mentioned here #11602 BubbleChart works without this parameter because it takes the default
rvalue from the dataset propertyradiusand it default value is 3.TS screams:
Property 'r' is missing in type '{ x: number; y: number; }' but required in type 'BubbleDataPoint'.but it doesn't affect the chart.