fix: Fix bugs with border size calculation#197
Merged
meowgorithm merged 2 commits intocharmbracelet:masterfrom May 1, 2023
Merged
fix: Fix bugs with border size calculation#197meowgorithm merged 2 commits intocharmbracelet:masterfrom
meowgorithm merged 2 commits intocharmbracelet:masterfrom
Conversation
meowgorithm
requested changes
Apr 29, 2023
Member
meowgorithm
left a comment
There was a problem hiding this comment.
Thanks for this! Do you mind excluding the changes to .gitignore from this PR? We like to keep our PRs very specific, and there are a lot of rules in there (like node stuff) that don’t apply to this type of project.
Author
|
Sure - just pushed @meowgorithm . I'll open a separate PR with the VSCode and Idea one (I got hit by Git wanting to version control those) |
meowgorithm
approved these changes
May 1, 2023
Member
|
Thank you so much for this one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.