Conversation
wait for the underlying context to finish. extract from #352
aymanbagabas
approved these changes
Apr 17, 2023
meowgorithm
reviewed
Apr 19, 2023
Member
There was a problem hiding this comment.
Per my chat with @muesli, it would be awesome if Wait() could return after the terminal state has been restored (internally, at the end of Program.shutdown).
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Contributor
Author
|
ah, I actually don't even need this, I can pass my own context with as per your request, pushed something I think will help |
meowgorithm
approved these changes
Apr 21, 2023
Member
meowgorithm
left a comment
There was a problem hiding this comment.
Nice! This is exactly how I solved for it in #726 — except your API design's much better.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait for the underlying context to finish.
extract from #352