fix: renderer: use newline instead of cud1 to move cursor down#1323
Merged
aymanbagabas merged 2 commits intomainfrom Feb 10, 2025
Merged
fix: renderer: use newline instead of cud1 to move cursor down#1323aymanbagabas merged 2 commits intomainfrom
aymanbagabas merged 2 commits intomainfrom
Conversation
Using cud1 (`\x1b[B`) won't scroll the terminal if the cursor is already at the bottom of the screen. Instead, use a newline character to move the cursor down and scroll the terminal if necessary. Fixes: #1322
Member
Author
|
Hey @antonmedv, this patch should resolve your last line disapearing issue. We're looking into the other Windows problems 🙂 |
|
Awesome! Cool! |
e4ecf4a to
a26fa58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using cud1 (
\x1b[B) won't scroll the terminal if the cursor is already at the bottom of the screen. Instead, use a newline character to move the cursor down and scroll the terminal if necessary.Fixes: #1322