Conversation
meowgorithm
requested changes
May 23, 2023
Member
meowgorithm
left a comment
There was a problem hiding this comment.
One small thing with locale, otherwise we're good to go.
I wonder if people need instructions on finding their locale? On unix systems I typically just call locale, but on Windows I believe it's a bit fussier. Given that perhaps we forgo it for now unless we start hear it's an issue, if you agree.
Contributor
Author
|
@meowgorithm added the locale here and added the locale to the PRs in Glow and Lip Gloss as well for the issue templates over there. |
ReallyLiri
pushed a commit
to ReallyLiri/bubbles
that referenced
this pull request
Jun 13, 2024
* docs: add issue template * chore(template): add locale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.