Added disableThanks option#1255
Conversation
🦋 Changeset detectedLatest commit: ad42c64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d9a639d:
|
70eb447 to
d9a639d
Compare
|
It'd be great to have this option indeed! In addition to accepting true/false, the option can also accept a RegExp for usernames. This will be useful for packages mostly maintained by one or two people. If 95% of changes are done by the same person, there's no need to say thanks to them every time. But a casual contributor can be mentioned. In the meantime, I managed to disable all thanks with a local pnpm patch: |
Co-authored-by: Marco Comi <marco.comi@pagopa.it>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
==========================================
+ Coverage 83.84% 83.85% +0.01%
==========================================
Files 56 56
Lines 2463 2465 +2
Branches 747 743 -4
==========================================
+ Hits 2065 2067 +2
Misses 392 392
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
related to my pr (#460) from very long ago :^) |
bluwy
left a comment
There was a problem hiding this comment.
Just noticed that I messed up the cherry-pick before and the option isn't called disableThanks anymore. Temporarily blocking this for now.
@beeequeue I think that idea makes sense too. Seems not too complicated to add so we can do it together in this PR.
|
Actually it's a bit tricky to refactor to handle the username filtering due to how it fetches the sources now, so I'm leaving it out from the changes. |
Hi,
While thanking users in changelogs is commendable and makes sense for public projects or projects with a large amount of contributors, it served no purpose in our private packages and we felt that it cluttered our changelogs (for example, we had dozen entries in a single release, all prefixed with
Thanks @Kauhsa!).So, I added option
disableThanksto@changesets/changelog-githubto disable this behaviour.