Skip to content

chore: Migrate to protoc-gen-es and extract generated code to its own package#1271

Merged
haines merged 1 commit intocerbos:mainfrom
haines:api
Nov 7, 2025
Merged

chore: Migrate to protoc-gen-es and extract generated code to its own package#1271
haines merged 1 commit intocerbos:mainfrom
haines:api

Conversation

@haines
Copy link
Copy Markdown
Member

@haines haines commented Nov 7, 2025

No description provided.

@haines haines force-pushed the api branch 8 times, most recently from 7ca44fc to 0b71b76 Compare November 7, 2025 13:46
…wn package

Signed-off-by: Andrew Haines <haines@cerbos.dev>
@haines haines marked this pull request as ready for review November 7, 2025 14:02
@haines haines requested a review from charithe November 7, 2025 14:18
@haines haines merged commit 9c8e4b6 into cerbos:main Nov 7, 2025
61 checks passed
@haines haines deleted the api branch November 7, 2025 14:19
@oxc
Copy link
Copy Markdown

oxc commented Nov 13, 2025

I appreciate that these packages are in 0.x range and don't follow semver convention, but it would also be highly appreciated if you could mention breaking changes in the CHANGELOG, for example new peer dependencies that need to be added.

@haines
Copy link
Copy Markdown
Member Author

haines commented Nov 13, 2025

Sorry, I wasn't expecting this to be a breaking change; I thought peer dependencies were installed automatically. What package manager are you using?

@oxc
Copy link
Copy Markdown

oxc commented Nov 13, 2025

In this project I'm using yarn. Don't know how other managers handle that.

In my experience, the peer dependencies are usually listed in the install commands in the README, but I have never given it much thought or investigation. From yarn 4, I only get a warning during install, which apparently wasn't enough in this case 😄

@haines
Copy link
Copy Markdown
Member Author

haines commented Nov 13, 2025

Ah ok, yeah it seems like Yarn is the outlier here. Both npm and pnpm install peer dependencies automatically unless they are marked as optional (which ours are not). The Yarn team seems to think you should have to install a plugin to get this behaviour (yarnpkg/yarn#1503 (comment)), or turn the warnings into errors yourself (yarnpkg/yarn#6011 (comment)) 🤷‍♂️

@oxc
Copy link
Copy Markdown

oxc commented Nov 13, 2025

I see. Thanks 👍🏻 Time to switch to pnpm 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants