chore: Migrate to protoc-gen-es and extract generated code to its own package#1271
chore: Migrate to protoc-gen-es and extract generated code to its own package#1271haines merged 1 commit intocerbos:mainfrom
protoc-gen-es and extract generated code to its own package#1271Conversation
7ca44fc to
0b71b76
Compare
…wn package Signed-off-by: Andrew Haines <haines@cerbos.dev>
|
I appreciate that these packages are in 0.x range and don't follow semver convention, but it would also be highly appreciated if you could mention breaking changes in the CHANGELOG, for example new peer dependencies that need to be added. |
|
Sorry, I wasn't expecting this to be a breaking change; I thought peer dependencies were installed automatically. What package manager are you using? |
|
In this project I'm using yarn. Don't know how other managers handle that. In my experience, the peer dependencies are usually listed in the install commands in the README, but I have never given it much thought or investigation. From yarn 4, I only get a warning during install, which apparently wasn't enough in this case 😄 |
|
Ah ok, yeah it seems like Yarn is the outlier here. Both npm and pnpm install peer dependencies automatically unless they are marked as optional (which ours are not). The Yarn team seems to think you should have to install a plugin to get this behaviour (yarnpkg/yarn#1503 (comment)), or turn the warnings into errors yourself (yarnpkg/yarn#6011 (comment)) 🤷♂️ |
|
I see. Thanks 👍🏻 Time to switch to pnpm 😄 |
No description provided.