Skip to content

rbd/admin: Fix snapshot schedule start-time format#1234

Merged
mergify[bot] merged 1 commit into
ceph:masterfrom
anoopcs9:fix-rbd-snapshot-schedule-test
Feb 27, 2026
Merged

rbd/admin: Fix snapshot schedule start-time format#1234
mergify[bot] merged 1 commit into
ceph:masterfrom
anoopcs9:fix-rbd-snapshot-schedule-test

Conversation

@anoopcs9

@anoopcs9 anoopcs9 commented Feb 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

The start‑time argument always accepted an ISO 8601 timestamp, but it wasn’t enforced until it was fixed recently. Therefore, it now conforms to the requirement in the corresponding tests.

fixes #1233

@anoopcs9
rbd/admin: Fix snapshot schedule start-time format
3aa1886 
The start‑time argument always accepted an ISO 8601 timestamp, but
it wasn’t enforced until it was fixed[1] recently. Therefore, it now
conforms to the requirement in the corresponding tests.

[1] ceph/ceph#66735

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Feb 27, 2026
@anoopcs9 anoopcs9 marked this pull request as ready for review February 27, 2026 13:12
@mergify mergify Bot added the queued label Feb 27, 2026
@mergify mergify Bot merged commit 80cd55a into ceph:master Feb 27, 2026
15 of 16 checks passed
@mergify

mergify Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

Rule: default

  • ✅ Entered queue — 2026-02-27 14:43 UTC
  • ✅ Checks passed · in-place
  • ✅ Merged — 2026-02-27 14:43 UTC · at 3aa18864742787a0954302fa3e31e55cb65484a2

This pull request spent 8 seconds in the queue, with no time running CI.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = check
    • check-neutral = check
    • check-skipped = check
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (pacific)
    • check-neutral = test-suite (pacific)
    • check-skipped = test-suite (pacific)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (quincy)
    • check-neutral = test-suite (quincy)
    • check-skipped = test-suite (quincy)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (reef)
    • check-neutral = test-suite (reef)
    • check-skipped = test-suite (reef)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (squid)
    • check-neutral = test-suite (squid)
    • check-skipped = test-suite (squid)

@mergify mergify Bot removed the queued label Feb 27, 2026
@anoopcs9 anoopcs9 deleted the fix-rbd-snapshot-schedule-test branch March 30, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@ansiwen ansiwen Awaiting requested review from ansiwen

Assignees

No one assigned

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test regresssion on main WRT RBD snapshot schedules

2 participants

@anoopcs9 @phlogistonjohn