Skip to content

admin/osd: Return blocklist expiration as time.Time#1209

Merged
mergify[bot] merged 1 commit into
ceph:masterfrom
anoopcs9:osd-blocklist-until-time
Dec 27, 2025
Merged

admin/osd: Return blocklist expiration as time.Time#1209
mergify[bot] merged 1 commit into
ceph:masterfrom
anoopcs9:osd-blocklist-until-time

Conversation

@anoopcs9

@anoopcs9 anoopcs9 commented Dec 16, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@anoopcs9 anoopcs9 force-pushed the osd-blocklist-until-time branch 2 times, most recently from 959f7da to 9dd1cb0 Compare December 16, 2025 10:16
@anoopcs9 anoopcs9 mentioned this pull request Dec 16, 2025
Merged
6 tasks
@anoopcs9 anoopcs9 force-pushed the osd-blocklist-until-time branch from 9dd1cb0 to cd997dc Compare December 16, 2025 10:46
@anoopcs9 anoopcs9 marked this pull request as ready for review December 16, 2025 12:27
@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Dec 16, 2025
phlogistonjohn
phlogistonjohn reviewed Dec 16, 2025
View reviewed changes
Comment thread common/admin/osd/osd_blocklist.go Outdated
Comment thread common/admin/osd/osd_blocklist.go
@anoopcs9 anoopcs9 force-pushed the osd-blocklist-until-time branch from cd997dc to bf03dfa Compare December 16, 2025 16:18
nixpanic
nixpanic reviewed Dec 16, 2025
View reviewed changes
Comment thread common/admin/osd/osd_blocklist.go Outdated
@nixpanic @anoopcs9
admin/osd: Return blocklist expiration as time.Time
0319a11 
Also make manual changes to adjust the API stability timeline for those
APIs, since one of the struct members it returns has changed type.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 force-pushed the osd-blocklist-until-time branch from bf03dfa to 0319a11 Compare December 17, 2025 05:48
@anoopcs9 anoopcs9 requested a review from nixpanic December 17, 2025 10:40
nixpanic
nixpanic approved these changes Dec 18, 2025
View reviewed changes

@nixpanic nixpanic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes the blocklisting API more practical to use.

@mergify mergify Bot added the queued label Dec 27, 2025
@mergify mergify Bot merged commit f7f1b64 into ceph:master Dec 27, 2025
16 of 17 checks passed
@mergify

mergify Bot commented Dec 27, 2025

Copy link
Copy Markdown
Contributor

Merge Queue Status

✅ The pull request has been merged at 0319a11

This pull request spent 4 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = check
    • check-neutral = check
    • check-skipped = check
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (pacific)
    • check-neutral = test-suite (pacific)
    • check-skipped = test-suite (pacific)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (quincy)
    • check-neutral = test-suite (quincy)
    • check-skipped = test-suite (quincy)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (reef)
    • check-neutral = test-suite (reef)
    • check-skipped = test-suite (reef)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (squid)
    • check-neutral = test-suite (squid)
    • check-skipped = test-suite (squid)

@mergify mergify Bot removed the queued label Dec 27, 2025
@anoopcs9 anoopcs9 deleted the osd-blocklist-until-time branch December 27, 2025 17:35
@anoopcs9 anoopcs9 mentioned this pull request Jan 8, 2026
Closed
@nixpanic nixpanic mentioned this pull request Feb 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@phlogistonjohn phlogistonjohn Awaiting requested review from phlogistonjohn

Assignees

No one assigned

Labels

API This PR includes a change to the public API of a go-ceph package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anoopcs9 @nixpanic @phlogistonjohn