Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #8504 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 148 148
Lines 18491 18491
Branches 3156 3156
=======================================
Hits 16169 16169
Misses 2033 2033
Partials 289 289
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
left a comment
There was a problem hiding this comment.
we need to ensure it works with kombu well ffirst
|
depends on celery/kombu#1790 |
auvipy
left a comment
There was a problem hiding this comment.
it is also passing in kombu so approving
|
@auvipy could you please release a new version with the change. |
|
Not before sept 30 |
@auvipy if you don't have any objections I can take care of that over the weekend. Redis 5 can be a nice upgrade indeed! P.S |
We can also finish the new patch release policy and try it out already to see if it works as expected, I'm eager to get it done so I can find time to handle the release soon if you're ok with that bro @auvipy |
|
let us first complete the release process template then we could go for it |
|
also we might need to revert another PR. Let me handle the next release first, but if i can't manage enough time, I will ping you to do so instead of me |
See new updates on the PR.
Sure np! |
Description
support redis-py 5.x, as there is no breaking change except dropping Python 3.7 support, https://github.com/redis/redis-py/releases/tag/v5.0.0